You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added reflectToAttribute: true to fix a Chrome specific issue where setting autocapitalize attribute does not set corresponding property and it remains undefined so the delegation observer fails to set it on the <input>.
This only affects autocapitalize - two other properties work fine, so I didn't add reflectToAttribute there.
While I don't really like inconsistency, this is the cleanest fix that I was able to come up with 🤷♂️
Hi @web-padawan , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 621c1e8
error: could not apply 621c1e8... fix: propagate autocapitalize attribute in Chrome (#5175)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Hi @web-padawan , this commit cannot be picked to 23.2 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 621c1e8
error: could not apply 621c1e8... fix: propagate autocapitalize attribute in Chrome (#5175)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow-components#4452
Added
reflectToAttribute: trueto fix a Chrome specific issue where settingautocapitalizeattribute does not set corresponding property and it remainsundefinedso the delegation observer fails to set it on the<input>.This only affects
autocapitalize- two other properties work fine, so I didn't addreflectToAttributethere.While I don't really like inconsistency, this is the cleanest fix that I was able to come up with 🤷♂️
See vaadin/flow-components#4452 (comment)
Type of change